Horton

Re: [PATCH] Suppress Clang 3.9 warnings

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>, David Steele <david@pgmasters.net>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-03-15T14:57:15Z
Lists: pgsql-hackers 
Noah Misch <noah@leadboat.com> writes:
> On Mon, Mar 13, 2017 at 06:35:53PM +0300, Aleksander Alekseev wrote:
>> + * Unfortunately in case of strlcat and strlcpy we can't trust tests
>> + * executed by Autotools if Clang > 3.6 is used.

> This is wrong on platforms that do have strlcpy() in libc.

Didn't you submit a patch to upstream autoconf awhile ago to fix the
AC_CHECK_DECLS test for this?  Seems like the correct solution is to
absorb that fix, either by updating to a newer autoconf release or by
carrying our own version of AC_CHECK_DECLS until they come out with one.

			regards, tom lane

Commits

  1. Suppress implicit-conversion warnings seen with newer clang versions.