Re: Fixing WAL instability in various TAP tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Andrew Dunstan <andrew@dunslane.net>, Noah Misch <noah@leadboat.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-28T19:00:13Z
Lists: pgsql-hackers
Attachments
- 0001-break-it.patch (text/x-diff) patch 0001
- 0002-fix-it.patch (text/x-diff) patch 0002
Mark Dilger <mark.dilger@enterprisedb.com> writes: > Perhaps having the bloom index messed up answers that, though. I think it should be easy enough to get the path to the heap main table fork and the bloom main index fork for both the primary and standby and do a filesystem comparison as part of the wal test. That would tell us if they differ, and also if the differences are limited to just one or the other. I think that's probably overkill, and definitely out-of-scope for contrib/bloom. If we fear that WAL replay is not reproducing the data accurately, we should be testing for that in some more centralized place. Anyway, I confirmed my diagnosis by adding a delay in WAL apply (0001 below); that makes this test fall over spectacularly. And 0002 fixes it. So I propose to push 0002 as soon as the v14 release freeze ends. Should we back-patch 0002? I'm inclined to think so. Should we then also back-patch enablement of the bloom test? Less sure about that, but I'd lean to doing so. A test that appears to be there but isn't actually invoked is pretty misleading. regards, tom lane
Commits
-
Fix instability in contrib/bloom TAP tests.
- cf26a8d8a75f 13.5 landed
- cea5624f6a23 14.1 landed
- 6bc6bd47cf71 15.0 landed
- 2d8a8b18fe5a 12.9 landed
-
Re-enable contrib/bloom's TAP tests.
- 7d1aa6bf1c27 15.0 landed