Horton

Re: Fixing WAL instability in various TAP tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>, Noah Misch <noah@leadboat.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-28T18:20:18Z
Lists: pgsql-hackers 
Mark Dilger <mark.dilger@enterprisedb.com> writes:
> Looking closer at the TAP test, it's not ORDERing the result set from the SELECTs on either node, but it is comparing the sets for stringwise equality, which is certainly order dependent.

Well, it's forcing a bitmap scan, so what we're getting is the native
ordering of a bitmapscan result.  That should match, given that what
we're doing is physical replication.  I think adding ORDER BY would
be more likely to obscure real issues than hide test instability.

			regards, tom lane

Commits

  1. Fix instability in contrib/bloom TAP tests.

  2. Re-enable contrib/bloom's TAP tests.