Horton

Re: Improving psql's \password command

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-18T00:14:28Z
Lists: pgsql-hackers 
"Bossart, Nathan" <bossartn@amazon.com> writes:
> You are right.  I'm not sure what I was thinking.  Attached a v3
> with that part removed.

Pushed with a little further tweaking --- mostly, I felt that
explicitly referring to SIGINT in the API names was too
implementation-specific, so I renamed things.

As you mentioned, there are several other simple_prompt() calls
that could usefully be improved.  (I think the one in startup.c
may be OK because we've not set up the SIGINT handler yet,
though.)  I wondered whether it's worth refactoring some more
to have just one function that sets up the context mechanism.

I was also of two minds about whether to add a context option
to pg_get_line_buf().  I stuck with your choice not to, but
it does look a bit inconsistent.

			regards, tom lane

Commits

  1. pg_receivewal, pg_recvlogical: allow canceling initial password prompt.

  2. Allow psql's other uses of simple_prompt() to be interrupted by ^C.

  3. Provide a variant of simple_prompt() that can be interrupted by ^C.

  4. Make psql's \password default to CURRENT_USER, not PQuser(conn).