Horton

Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Date: 2019-08-18T00:59:56Z
Lists: pgsql-bugs 
Andres Freund <andres@anarazel.de> writes:
> Hm. This made me think: Why is
>                 if (concurrentCons > FD_SETSIZE - 1)
> a useful test / error message?

Good point, it's not.  Subtracting off 10 or so might be reasonable.

> What is the reason that this doesn't use poll() in the first place?

We still support platforms without that, no?  Windows, for one.

			regards, tom lane

Commits

  1. Fix error handling of vacuumdb when running out of fds

  2. Fix error handling of vacuumdb and reindexdb when running out of fds

  3. Fix compilation failure of vacuumdb and reindexdb with OpenBSD

  4. Improve Assert output

  5. Refactor parallelization processing code in src/bin/scripts/

  6. vacuumdb: enable parallel mode