Horton

Re: xlog location arithmetic

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Euler Taveira de Oliveira <euler@timbira.com>, Robert Haas <robertmhaas@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2012-03-09T14:37:35Z
Lists: pgsql-hackers 
Fujii Masao <masao.fujii@gmail.com> writes:
> Euler proposed one more patch upthread, which replaces pg_size_pretty(bigint)
> with pg_size_pretty(numeric) so that pg_size_pretty(pg_xlog_location_diff())
> succeeds. It's also worth committing this patch?

Why would it be useful to use pg_size_pretty on xlog locations?
-1 because of the large expense of bigint->numeric->whatever conversion
that would be added to existing uses.

			regards, tom lane