Re: [PATCH] New [relation] option engine

Nikolay Shaplov <dhyan@nataraj.su>

From: Nikolay Shaplov <dhyan@nataraj.su>

To: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>

Date: 2022-05-04T15:15:51Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Tighten test_predtest's input checks, and improve error messages.
- 00ac25a3c365 17.0 cited
Avoid reference to nonexistent array element in ExecInitAgg().
- 92957ed98c5c 16.0 cited
Clean up newlines following left parentheses
- c4f113e8fef9 15.0 cited

Attachments

new_options_take_two_v02.diff (text/x-patch) patch v2

В письме от суббота, 16 апреля 2022 г. 17:15:34 MSK пользователь Nikolay 
Shaplov написал:

Changed NoLock to AccessShareLock. This will remove last FIXME from the patch.

As more experienced pg-developers told me, you can call relation_open with 
AccessShareLock, on a table you are going to work with, any time you like, 
without being ashamed about it.

But this lock is visible when you have prepared transaction, so have to update
twophase test of test_decoding extension.


-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su