Horton

Re: Orphan page in _bt_split

Konstantin Knizhnik <knizhnik@garret.ru>

View thread
From: Konstantin Knizhnik <knizhnik@garret.ru>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-14T13:40:54Z
Lists: pgsql-hackers

Attachments

On 13/09/2025 10:10 PM, Peter Geoghegan wrote:
> On Wed, Sep 3, 2025 at 2:25 AM Konstantin Knizhnik<knizhnik@garret.ru> wrote:
>> Do you suggest to replace `PageGetTempPage` with using local buffers?
>> Or may be change `PageGetTempPage*` to accept parameter with provided
>> local buffer?
> I think that _bt_split could easily be switched over to using 2 local
> PGAlignedBlock variables, removing its use of PageGetTempPage. I don't
> think that it is necessary to consider other PageGetTempPage callers.
>

Attached please find updated version of the patch which uses 
PGAlignedBlock instead of PageGetTempPage.