Horton
Menu

Re: Pgoutput not capturing the generated columns

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, "Shinoda, Noriyoshi (SXD Japan FSI)" <noriyoshi.shinoda@hpe.com>, Daniel Gustafsson <daniel@yesql.se>, vignesh C <vignesh21@gmail.com>, Michael Paquier <michael@paquier.xyz>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>
Date: 2025-01-24T03:09:07Z
Lists: pgsql-hackers 
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Fri, Jan 24, 2025 at 4:41 AM Peter Smith <smithpb2250@gmail.com> wrote:
>> However, in hindsight, I am not sure that the column should have been
>> renamed 'pubgencols_type' in the first place because I cannot find any
>> other catalogs with an underscore in their column names.

> See pg_rewrite.ev_type for a similar case.

I think the problem is not so much the underscore as the
inconsistency.  You've got "pub", "gen", and "cols" run together,
but then you feel a need to separate "type"?  It just looks wrong,
the more so because no other column in that catalog has an
underscore in its name.

I see that this was carried over from a related C typedef name,
but users aren't going to see that.  They'll just see that
somebody couldn't be bothered to maintain a consistent style.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.