Horton

Re: Deficient error handling in pg_dump and pg_basebackup

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2021-11-17T19:19:20Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 16, 2021 at 10:26:11PM -0500, Tom Lane wrote:
>> However, that's largely orthogonal to any of the things my proposed
>> patches are trying to fix.  If you want to review the patches without
>> considering the fsync-error-handling problem, that'd be great.

> I have looked at them upthread, FWIW:
> https://www.postgresql.org/message-id/YYtSj5vlWp5faVXz@paquier.xyz
> Your proposals still look rather sane to me, after a second look.

Pushed then; thanks for reviewing that.  We can consider the fsync
error question at leisure.

			regards, tom lane

Commits

  1. Clean up error handling in pg_basebackup's walmethods.c.

  2. Handle close() failures more robustly in pg_dump and pg_basebackup.

  3. Add support for LZ4 compression in pg_receivewal