Horton

Re: define bool in pgtypeslib_extern.h

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrew Gierth <andrew@tao11.riddles.org.uk>, Michael Meskes <meskes@postgresql.org>
Date: 2019-11-06T14:54:25Z
Lists: pgsql-hackers 
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Mon, Oct 28, 2019 at 11:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A plausible alternative is to do
>> 
>> -#define bool char
>> +#define bool unsigned char
>> 
>> which is correct on platforms where we don't use <stdbool.h>,
>> and is at least no worse than now on those where we do.  In
>> practice, since we know sizeof(_Bool) == 1 on platforms where
>> we use it, this is probably just fine for dtrace's purposes.

> +1 for the second alternative as it will make it similar to c.h.

Yeah, that's the minimum-risk alternative.  I'll go make it so.

			regards, tom lane

Commits

  1. Fix ecpglib.h to declare bool consistently with c.h.

  2. Move declaration of ecpg_gettext() to a saner place.

  3. Sync our DTrace infrastructure with c.h's definition of type bool.

  4. Get rid of useless/dangerous redefinition of bool in ECPG.