Horton

Re: pgsql: Add support for coordinating record typmods among parallel worke

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-committers <pgsql-committers@postgresql.org>
Date: 2017-09-15T14:55:17Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> The attached patch fixes the problem
> by getting rid of the code that accesses shmem in the detach hook.
> With this patch applied installcheck survives on a cluster with
> force_parallel_worker=regress.

In hopes of getting the buildfarm back to green, I went ahead and pushed
a slightly more aggressive form of this --- I took out the worker-specific
detach function altogether.  We can resurrect it if we ever have a more
plausible idea of how to do worker recycling, but for now I don't see a
reason to waste bytes on useless and incorrect code.

			regards, tom lane

Commits

  1. Get rid of shared_record_typmod_registry_worker_detach; it doesn't work.

  2. Add support for coordinating record typmods among parallel workers.

  3. Add minimal regression test for blessed record type transfer.