Horton

Re: pgsql: Fix "base" snapshot handling in logical decoding

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org, 2q-andrew@alvin.alvh.no-ip.org
Date: 2018-06-29T23:02:04Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> On 2018-Jun-28, Tom Lane wrote:
>>> According to buildfarm member friarbird, and as confirmed here,
>>> the contrib/test_decoding/specs/oldest_xmin.spec test added by this
>>> commit fails under CLOBBER_CACHE_ALWAYS.

> I suppose 60 seconds (isolationtester's default timeout) is just not
> enough time for those machines.  We could increase it to 180 seconds and
> see if that's enough to make them pass ...

What I want to know is why this test is doing a database-wide VACUUM FULL
in the first place.  If that isn't profligate wastage of testing cycles,
why not?

			regards, tom lane

Commits

  1. Reduce cost of test_decoding's new oldest_xmin test

  2. Fix "base" snapshot handling in logical decoding