Horton
Menu

Re: ecpg - GRANT bug

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Lee Kindness <lkindness@csl.co.uk>
Cc: pgsql-bugs@postgresql.org, maves@csl.co.uk, Michael Meskes <meskes@postgresql.org>
Date: 2001-10-12T17:18:49Z
Lists: pgsql-bugs, pgsql-hackers 
Lee Kindness <lkindness@csl.co.uk> writes:
> ***************
> *** 1693,1699 ****
  
>   GrantStmt:  GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
>   				{
> ! 					$$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
>   				}
>   		;
  
> --- 1693,1699 ----
  
>   GrantStmt:  GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
>   				{
> ! 					$$ = cat_str(7, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
>   				}
>   		;


Uh, isn't the correct fix

! 					$$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7, $8);

ISTM your patch loses the opt_with_grant clause.  (Of course the backend
doesn't currently accept that clause anyway, but that's no reason for
ecpg to drop it.)

			regards, tom lane