Horton

Re: [postgresql 10 beta3] unrecognized node type: 90

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-bugs@postgresql.org
Date: 2017-08-11T20:20:51Z
Lists: pgsql-bugs, pgsql-hackers 
I wrote:
> So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> to plug it into ExecReScan.  From which we may draw depressing conclusions
> about how much it's been tested.

While I'm bitching ... the code coverage report at

https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html

also leaves one with less than a warm feeling about the extent of test
coverage on this file.  heap_compare_slots isn't invoked even once?

			regards, tom lane

Commits

  1. Separate reinitialization of shared parallel-scan state from ExecReScan.

  2. Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b.

  3. Force rescanning of parallel-aware scan nodes below a Gather[Merge].

  4. Fix ExecReScanGatherMerge.

  5. Add missing call to ExecReScanGatherMerge.