Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Mike Fowler <mike@mlfowler.com>

Cc: Peter Eisentraut <peter_e@gmx.net>, David Fetter <david@fetter.org>, Bruce Momjian <bruce@momjian.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Round Robin Reviewers <pgsql-rrreviewers@postgresql.org>

Date: 2010-08-08T19:18:17Z

Lists: pgsql-hackers

Mike Fowler <mike@mlfowler.com> writes:
> On 06/08/10 20:55, Peter Eisentraut wrote:
>> On fre, 2010-08-06 at 09:04 +0100, Mike Fowler wrote:
>>> If the patch is to be committed, does it make sense for me to refine
>>> it such that it uses the new xpath internal function you extracted in
>>> the xmlexists patch?
>> 
>> Yes, you can probably shrink this patch down to about 20 lines.

> Updated the patch so that it will apply to head and re-worked the 
> function to use the new xpath internal function.

Applied with minor corrections (improved docs, fixed regression tests,
adjusted OIDs for CVS HEAD).

			regards, tom lane