Horton

Re: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, christoph.berg@credativ.de, pgsql-bugs@lists.postgresql.org
Date: 2022-06-10T19:47:09Z
Lists: pgsql-bugs 
Michael Paquier <michael@paquier.xyz> writes:
> On June 11, 2022 1:12:11 AM GMT+09:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> In any case, I now agree with Robert's upthread objection that
>> this should not have been back-patched.  It's a nontrivial
>> behavioral change and it's not clear that it's 100% without
>> downsides.  I particularly do not want to ship 14.4 with this,
>> because we really need a clean release with no new regressions.

> Okay. An issue here is that I don't have my laptop at hand until 14.4 wraps, which would be around Monday morning my time. Could somebody do that instead?

OK, I can take care of it.

			regards, tom lane

Commits

  1. Tweak behavior of psql --single-transaction depending on ON_ERROR_STOP

  2. Doc: remove a04ccf6df from release notes, now that it's reverted.

  3. Revert "Fix psql's single transaction mode on client-side errors with -c/-f switches".

  4. Fix psql's single transaction mode on client-side errors with -c/-f switches