Horton

Re: Reorganize GUC structs

Anton Voloshin <a.voloshin@postgrespro.ru>

View thread View on postgr.es
From: Anton Voloshin <a.voloshin@postgrespro.ru>
To: Peter Eisentraut <peter@eisentraut.org>, Álvaro Herrera <alvherre@kurilemu.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-06-22T08:15:50Z
Lists: pgsql-hackers

Attachments

Hello,

On 19/11/2025 10:57, Peter Eisentraut wrote:
 > Ok, committed that way.

in fce7c73fb (Sort guc_parameters.dat alphabetically by name) two 
extraneous newlines have been kept in the guc_parameters.dat: before 
archive_command and before seq_page_cost. I suggest to remove them, 
since they don't seem to mark any important spots anyway, see the 
attached patch.

Found by accident after re-sorting guc_parameters.dat in our fork with 
sort_guc_parameters.pl (also attached just in case). This is a 
single-use script, not meant to be robust or tidy.

Best regards,
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

Commits

  1. Remove extraneous newlines from guc_parameters.dat

  2. Fix NLS for incorrect GUC enum value hint message

  3. Clean up qsort comparison function for GUC entries

  4. Sort guc_parameters.dat alphabetically by name

  5. Reorganize GUC structs

  6. Change config_generic.vartype to be initialized at compile time

  7. Use designated initializers for guc_tables

  8. Change reset_extra into a config_generic common field

  9. Add some const qualifiers

  10. Modernize some for loops