Re: Common function for percent placeholder replacement
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
pgsql-hackers@postgresql.org
Date: 2022-12-14T17:40:03Z
Lists: pgsql-hackers
Justin Pryzby <pryzby@telsasoft.com> writes:
> On Wed, Dec 14, 2022 at 08:31:02AM +0100, Peter Eisentraut wrote:
>> + return replace_percent_placeholders(base_command, "df", (const char *[]){target_detail, filename});
> This is a "compound literal", which I gather is required by C99.
> But I don't think that's currently being exercised, so I wonder if it's
> going to break some BF members.
It's pretty illegible, whatever it is. Could we maybe expend a
few more keystrokes in favor of readability?
regards, tom lane
Commits
-
Code cleanup
- 881fa869c6b0 16.0 landed
-
Common function for percent placeholder replacement
- c96de2ce1782 16.0 landed