Re: Teach predtest about IS [NOT] <boolean> proofs
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Coleman <jtc331@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-25T21:53:06Z
Lists: pgsql-hackers
Attachments
- v7-0002-Teach-predtest.c-about-BooleanTest.patch (text/x-diff) patch v7-0002
- v6-0003-Add-temporary-all-permutations-test.patch (text/x-diff) patch v6-0003
James Coleman <jtc331@gmail.com> writes: > [ v6 patchset ] I went ahead and committed 0001 after one more round of review statements; my bad). I also added the changes in test_predtest.c from 0002. I attach a rebased version of 0002, as well as 0003 which isn't changed, mainly to keep the cfbot happy. I'm still not happy with what you did in predicate_refuted_by_recurse: it feels wrong and rather expensively so. There has to be a better way. Maybe strong vs. weak isn't quite the right formulation for refutation tests? regards, tom lane
Commits
-
Refactor predicate_{implied,refuted}_by_simple_clause.
- c7076ba6ad1c 17.0 landed