Horton

Re: Page Scan Mode in Hash Index

Jesper Pedersen <jesper.pedersen@redhat.com>

View thread View on postgr.es
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-29T21:06:13Z
Lists: pgsql-hackers 
Hi,

On 03/27/2017 09:34 AM, Ashutosh Sharma wrote:
> Hi,
>
>> I think you should consider refactoring this so that it doesn't need
>> to use goto.  Maybe move the while (offnum <= maxoff) logic into a
>> helper function and have it return itemIndex.  If itemIndex == 0, you
>> can call it again.
>
> okay, Added a helper function for _hash_readpage(). Please check v4
> patch attached with this mail.
>
 >>
>> This is not a full review, but I'm out of time for the moment.
>
> No worries. I will be ready for your further review comments any time.
> Thanks for the review.
>

This patch needs a rebase.

Best regards,
  Jesper

Commits

  1. Remove lsn from HashScanPosData.

  2. Fix trivial mistake in README.

  3. hash: Implement page-at-a-time scan.

  4. Reduce pinning and buffer content locking for btree scans.