Re: pg_dumpall misses --no-toast-compression

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-17T14:38:15Z
Lists: pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 17 May 2021, at 03:12, Michael Paquier <michael@paquier.xyz> wrote:
>> I have bumped into $subject while playing with this feature, and this
>> can be really useful to be able to reset the compression method for
>> all the tables at restore.  The patch is simple but that's perhaps too
>> late for 14, so I am adding it to the next CF.

> I think there is a reasonable case to be made for this fixing an oversight in
> bbe0a81db69bd10bd166907c3701492a29aca294 as opposed to adding a brand new
> feature.  Save for --no-synchronized-snapshots all --no-xxx options in pg_dump
> are mirrored in pg_dumpall.

+1, seems more like fixing an oversight than anything else.

			regards, tom lane



Commits

  1. Add --no-toast-compression to pg_dumpall

  2. Allow configurable LZ4 TOAST compression.