Re: Ragged latency log data in multi-threaded pgbench
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Cc: Greg Smith <greg@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-03-16T02:02:12Z
Lists: pgsql-hackers
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes: > Greg Smith <greg@2ndquadrant.com> wrote: >> It looks like the switch between clients running on separate workers can >> lead to a mix of their respective lines showing up though. > Oops. There might be two solutions for the issue: > 1. Use explicit locks. The lock primitive will be pthread_mutex for > multi-threaded implementations or semaphore for multi-threaded ones. > 2. Use per-thread log files. > File names would be "pgbench_log.<main-process-id>.<thread-id>". I think #1 is out of the question, as the synchronization overhead will do serious damage to the whole point of having a multithreaded pgbench. #2 might be a reasonable idea. regards, tom lane