Horton
Menu

Re: Outstanding patches

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@dcc.uchile.cl>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2002-11-07T18:44:21Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> On Thu, Nov 07, 2002 at 12:27:05AM -0500, Tom Lane wrote:
>> CLUSTER ALL patch: I have a problem with this, specifically the fact
>> that it changes CLUSTER into a multi-transaction operation.

> That was your suggestion...

Well, it'd be okay (IMHO anyway) if it only happened for CLUSTER ALL.
You've built it in a way that the restriction applies to single-table
CLUSTERs, which is an unnecessary step backwards.

What I think I'd like to see is

	CLUSTER index ON table	-- does not hack transactions
	CLUSTER table -- recluster a table, does not hack transactions
	CLUSTER -- recluster all tables, works like VACUUM

This would allow people to build functions that do selective CLUSTERing,
at the price of holding more exclusive locks.

			regards, tom lane