Re: LLVM breakage on seawasp

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-24T20:57:56Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On August 24, 2019 1:08:11 PM PDT, Thomas Munro <thomas.munro@gmail.com> wrote:
>> That's because they just moved to C++14 and replaced their own
>> llvm::make_unique<> with std::make_unique<>:
>> https://github.com/llvm-mirror/llvm/commit/114087caa6f95b526861c3af94b3093d9444c57b
>> Perhaps we'll need some macrology to select between llvm and std
>> versions?  I am guessing we can't decree that PostgreSQL's minimum C++
>> level is C++14 and simply change it to std::make_unique.

So we're depending on APIs that upstream doesn't think are stable?

			regards, tom lane



Commits

  1. Don't rely on llvm::make_unique.