Horton

Re: pg_rewind WAL segments deletion pitfall

torikoshia <torikoshia@oss.nttdata.com>

View thread View on postgr.es
From: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz, pgsql-hackers@postgresql.org, bungina@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2023-11-09T06:30:56Z
Lists: pgsql-bugs, pgsql-hackers 
On 2023-11-06 23:58, Alexander Kukushkin wrote:
> Hi Torikoshia,
> 
> On Thu, 2 Nov 2023 at 04:24, torikoshia <torikoshia@oss.nttdata.com>
> wrote:
> 
>>> +extern void preserve_file(char *filepath);
>> 
>> Is this necessary?
>> This function was defined in older version patch, but no longer
>> seems to
>> exist.
>> 
>> +# We use "perl -e 'exit(1)'" as a alternative to "false", because
>> the
>> last one
>> 'a' should be 'an'?
> 
> Thanks for the feedback
> 
> Please find the new version attached.
Thanks for the update!

I've set the CF entry to "Ready for Committer".

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation

Commits

  1. Fix newly introduced 010_keep_recycled_wals.pl

  2. Avoid deleting critical WAL segments during pg_rewind