Horton

Re: Meson build updates

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tristan Partin <tristan@neon.tech>, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2023-06-12T21:24:26Z
Lists: pgsql-hackers 
On 12.06.23 20:48, Tristan Partin wrote:
> Attached you will find a v3 with the offending commits removed. I did
> leave the overrides in since you didn't mention it in your last email.

Patches 1-14 look ok to me.  (But I didn't test anything, so some 
caveats about whether the non-cosmetic patches actually work apply.)  If 
we're fine-tuning the capitalization the options descriptions, let's 
also turn "tap tests" into "TAP tests" and "TCL" into "Tcl".

Patch 15 about the wrap integration, I'm not sure.  I share the concerns 
about whether this is worth maintaining.  Maybe put this patch into the 
commitfest separately, to allow for further study and testing.  (The 
other patches, if they are acceptable, ought to go into PG16, I think.)

Commits

  1. meson: Make detection of python more robust

  2. meson: Pass more feature option through to required kwargs

  3. meson: Tie adding C++ support to the llvm Meson option

  4. meson: Fix intl misspelling

  5. meson: Use a better error message in an impossible case

  6. meson: Make some Meson style more consistent with surrounding code

  7. meson: Fix some grammar usage in Meson comments

  8. meson: Mention the correct way to disable readline support

  9. meson: Remove old comment

  10. meson: Use the not_found_dep constant

  11. meson: Attach colon to keyword argument

  12. meson: Use consistent Meson option description formats

  13. meson: Use consistent casing in Meson option descriptions

  14. meson: Remove triple-quoted strings