Horton

Re: Windows: Wrong error message at connection termination

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Lars Kanis <lars@greiz-reinsdorf.de>
Cc: pgsql-hackers@postgresql.org
Date: 2021-11-17T22:01:37Z
Lists: pgsql-hackers 
Lars Kanis <lars@greiz-reinsdorf.de> writes:
> Explicit closing the socket before process termination leads to a 
> graceful close even on Windows. That is done by the attached patch. I 
> think delivering the correct error message to the user is much more 
> important that closing the process in sync with the socket.

Per the comment immediately above this, it's intentional that we don't
close the socket.  I'm not really convinced that this is an improvement.

Can we get anywhere by using shutdown(2) instead of close(), ie do a
half-close?  I have no idea what Windows thinks the semantics of that
are, but it might be worth trying.

			regards, tom lane

Commits

  1. On Windows, close the client socket explicitly during backend shutdown.