Re: libpq should not look up all host addresses at once
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-08-13T19:46:34Z
Lists: pgsql-hackers
Attachments
- libpq-delay-getaddrinfo-docs.patch (text/x-diff) patch
Fabien COELHO <coelho@cri.ensmp.fr> writes: > Patch compiles, global "make check" ok, although I'm unsure whether the > feature is actually tested somewhere. I think not:-( Yeah, it's hard to test this stuff without either opening up security hazards or making unwarranted assumptions about the local network setup. I think that the standard regression tests only use Unix-socket communication (except on Windows) for exactly that reason, and that makes it hard to do anything much about regression-testing this feature. > As you noted in another message, a small doc update should be needed. Check. Proposed doc patch attached. (Only the last hunk is actually specific to this patch, the rest is cleanup that I noticed while looking around for possibly-relevant text.) > I'd consider wrapping some of the logic. I'd check the port first, then > move the host resolution stuff into a function. Don't really see the value of either ... regards, tom lane
Commits
-
In libpq, don't look up all the hostnames at once.
- c781a066ea4f 11.0 landed
- 5ca00774194d 12.0 landed
- 6953daf08e6b 10.6 landed