Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
Hao Lee <mixtrue@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>,
Andrew Dunstan <andrew@dunslane.net>
Date: 2018-05-15T17:29:24Z
Lists: pgsql-hackers
Mark Dilger <hornschnorter@gmail.com> writes: >> On May 15, 2018, at 10:20 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Hm. I'm not sure what our nominal support range for Visual Studio is. >> I see that mastodon (running VS2005) and currawong (running VS2008) >> haven't reported on HEAD lately, and I think they may have been shut >> down intentionally due to desupport? But if your build still works >> then it seems like we could continue to support VS2008. > I don't have a strong opinion on that. I could also look to upgrade > to a newer version. Generally, I try to build using the oldest > supported version rather than the newest. What is the next oldest > working test machine you have? thrips is described as running VS2010, though I'm not sure how to verify that it's not been updated. The make log shows c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\AMD64\CL.exe but is "10.0" the same thing as "2010"? regards, tom lane
Commits
-
Fix for globals.c- c.h must come first
- e2b83ff556de 11.0 landed
-
Allow group access on PGDATA
- c37b3d08ca68 11.0 cited
-
Refactor dir/file permissions
- da9b580d8990 11.0 cited