Re: BUG #16939: Plural interval for negative singular

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Gavin Flower <GavinFlower@archidevsys.co.nz>, Noah Misch <noah@leadboat.com>, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2021-04-28T03:43:10Z
Lists: pgsql-bugs
I wrote:
> Hm.  We actually document PQprint.  While the other two entry points
> in that file aren't documented, they are listed in exports.txt,
> which means somebody *could* be calling them.  I think we'd at least
> have to go through a long deprecation period before we could consider
> removing them.

Meanwhile, returning to the point at hand in this thread: AFAICS
from a quick review of the git logs, the last intentional changes
of user-visible behavior in fe-print.c were more than 20 years ago.
Since then it's only seen in-passing bug fixes, such as libpq-wide
fixes of signal handling.

So, to the extent that this code has any use at all it's for
legacy applications.  I don't think we should be making random
changes in its behavior for at-best-weak reasons.

In short, I'm now a vote to revert every single bit of 5da9868ed.

			regards, tom lane



Commits

  1. In messages, use singular nouns for -1, like we do for +1.