Horton

Re: [PATCH] lock_timeout and common SIGALRM framework

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Marc Cousin <cousinmarc@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Hans-Juergen Schoenig <hs@cybertec.at>, Ants Aasma <ants@cybertec.at>, Robert Haas <robertmhaas@gmail.com>
Date: 2012-07-13T22:23:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix Windows implementation of PGSemaphoreLock.

Boszormenyi Zoltan <zb@cybertec.at> writes:
>>> Try SET deadlock_timeout = 0;

Actually, when I try that I get

ERROR:  0 is outside the valid range for parameter "deadlock_timeout" (1 .. 2147483647)

So I don't see any bug here.  The places that are unconditionally doing
"enable_timeout_after(..., DeadlockTimeout);" are perfectly fine.  The
only place that might need an if-test has already got one:

          if (StatementTimeout > 0)
!             enable_timeout_after(STATEMENT_TIMEOUT, StatementTimeout);
          else
!             disable_timeout(STATEMENT_TIMEOUT, false);


			regards, tom lane