Re: Failure in commit_ts tap tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-21T16:09:14Z
Lists: pgsql-hackers
Pavan Deolasee <pavan.deolasee@gmail.com> writes:
> On Sat, Jan 21, 2017 at 9:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, but what of the "null" value? Also, I get
>>
>> $ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");'
>> Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
>> Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1.
>> ok 1 - ok
> It declares the test as "passed", right?
Oh! So it does. That is one darn weird behavior of the != operator.
> I am not saying that's a correct
> behaviour, but that's why we didn't catch the problem earlier.
Check. Mystery solved.
There's still the point that we're not actually exercising this script
in the buildfarm ...
regards, tom lane
Commits
-
Remove test for COMMENT ON DATABASE
- 7fb29ea9c626 9.5.6 landed
- 56b42a334167 9.6.2 landed
- 331f8c311b7b 10.0 landed
-
tests: Use the right Perl operator
- a600ee9e3fcc 10.0 landed