Re: static-if-inline
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-10-08T16:04:52Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > What's being done in this patch is exactly what would be done in the > ilist code. So if there are problems with this, please speak up. Stylistic gripe: in palloc.h you didn't follow the pattern of #ifndef USE_INLINE extern ... #endif before (rather than after) the function definitions. Nitpicky I know, but if we're trying to create a pattern, we should be consistent. The comment added in c.h has some grammar issues, too. Looks good otherwise. regards, tom lane