Horton

Re: pg_execute_from_file review

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-11-29T16:12:58Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew@dunslane.net> writes:
> I'm not sure why you need either "from". It just seems like a noise 
> word. Maybe we could use pg_execute_query_file() and 
> pg_execute_query_string(), which would be fairly clear and nicely 
> symmetrical.

+1, but I think "query" is also a noise word here.
Why not just "pg_execute_file" and "pg_execute_string"?

			regards, tom lane