Horton

Re: master make check fails on Solaris 10

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Wagner <vitus@wagner.pp.ru>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-01-18T06:47:46Z
Lists: pgsql-hackers 
Victor Wagner <vitus@wagner.pp.ru> writes:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Attached is a draft patch to incorporate Victor's slimmed-down test
>> into configure.  If you have a chance, could you confirm it does
>> the right thing on your Sparc machine?

> It seems that what it does is not exactly a right thing.
> I've applied it to commit 9c7d06d60680 in master and see following
> checking for __int128 alignment bug... ok
> As far as I understand your patch, there should be:
> checking for __int128 alignment bug... broken

Yes, that's what I expected to happen.

> Then in the pg_config.h I see
> /* The normal alignment of `PG_INT128_TYPE', in bytes. */
> #define ALIGNOF_PG_INT128_TYPE 16
> /* Define to the name of a signed 128-bit integer type. */
> #define PG_INT128_TYPE __int128

That's what I'd expect if configure thinks all's well :-(

> However, make check passes. 

Uh ... how could that be?  If the output of configure is exactly
the same as before the patch, how could the end result be different?

> We, Marina and I would continue investigation.

I look forward to some results ... but I'm going to bed now ...

			regards, tom lane

Commits

  1. Extend configure's __int128 test to check for a known gcc bug.

  2. Reorder C includes

  3. Ability to advance replication slots

  4. doc: add JSON acronym

  5. Expression evaluation based aggregate transition invocation.

  6. Change some bogus PageGetLSN calls to BufferGetLSNAtomic

  7. Prevent int128 from requiring more than MAXALIGN alignment.

  8. Rearrange c.h to create a "compiler characteristics" section.

  9. Make OWNER TO subcommand mention consistent