Horton

Re: moving some code out of explain.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2025-02-27T21:48:01Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> OK, here is v2. One slightly unfortunate thing about this is that we
> end up with a line that is over 80 characters:

> extern DestReceiver *CreateExplainSerializeDestReceiver(struct
> ExplainState *es);

> Aside from perhaps shortening the function name, I don't see how to avoid that.

Can't get terribly excited about that.  But speaking of
CreateExplainSerializeDestReceiver, I see that a declaration
of it is still there at the bottom of explain.h:

    extern DestReceiver *CreateExplainSerializeDestReceiver(ExplainState *es);

    #endif							/* EXPLAIN_H */

Oversight I assume?

			regards, tom lane

Commits

  1. Avoid including explain.h in explain_format.h and explain_dr.h

  2. Create explain_dr.c and move DestReceiver-related code there.

  3. Create explain_format.c and move relevant code there.