Thread

Re: Set notice receiver before libpq connection startup

Peter Eisentraut <peter@eisentraut.org> — 2026-05-27T17:56:50Z

On 23.05.26 01:56, Chao Li wrote:
> 
> 
>> On May 22, 2026, at 23:28, Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>> On Fri, May 22, 2026 at 11:56 PM Chao Li <li.evan.chao@gmail.com> wrote:
>>> PFA v4, just removed conn NULL check.
>>
>> Thanks for updating the patch! I've pushed it.
>>
>> Regards,
>>
>> -- 
>> Fujii Masao
> 
> Thanks for pushing and still working hard during the PGConf.

The committed patch violates the .gitattributes whitespace rules:

git show --check 06a5c3cdef02

contrib/postgres_fdw/connection.c:651: indent with spaces.
+                                                   /* expand_dbname = 
*/ false);

It is unfortunate that pgindent produces this layout that contradicts 
the git configuration.  (The current formatting also doesn't look like 
what I would produce in an editor, so I think git is right here.)

Maybe we could reformat this slightly to avoid that?  (unless someone 
wants to try to fix pgindent)