Horton

Re: ALTER DATABASE RESET with unexistent guc doesn't report an error

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vitaly Davydov <v.davydov@postgrespro.ru>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Kirill Reshke <reshkekirill@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-12T22:12:47Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name.

I wrote:
> Looking at the patch, the delta in database.out raises
> another question:
>  ALTER DATABASE regression_tbd RENAME TO regression_utf8;
>  ALTER DATABASE regression_utf8 SET TABLESPACE regress_tblspace;
>  ALTER DATABASE regression_utf8 RESET TABLESPACE;
> +ERROR:  unrecognized configuration parameter "tablespace"
>  ALTER DATABASE regression_utf8 CONNECTION_LIMIT 123;
> The author of this bit of test script evidently thought that
> ALTER ... RESET TABLESPACE is the inverse of ALTER ... SET TABLESPACE,
> and what we are seeing is that it is not.  That may be a bug in
> itself, but it's not what Vitaly is on about, IIUC.

That was in fact a test bug, now corrected at 4adb0380b.
I've substituted a more on-point test case, wordsmithed the
comment a little bit, and pushed it.

Thanks for the report and patch!

			regards, tom lane