Horton

Re: pgsql: Fix "base" snapshot handling in logical decoding

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Date: 2018-06-29T03:53:10Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix "base" snapshot handling in logical decoding

According to buildfarm member friarbird, and as confirmed here,
the contrib/test_decoding/specs/oldest_xmin.spec test added by this
commit fails under CLOBBER_CACHE_ALWAYS.

friarbird's error output doesn't seem to be getting captured by the
buildfarm script, but what I see is

***************
*** 16,21 ****
--- 16,22 ----
  
  step s1_commit: COMMIT;
  step s0_vacuum: VACUUM FULL;
+ ERROR:  canceling statement due to user request
  step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isolation_s
lot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
  data           
  
which looks like it might just be a timeout problem.

			regards, tom lane

Commits

  1. Reduce cost of test_decoding's new oldest_xmin test

  2. Fix "base" snapshot handling in logical decoding