Horton

Re: regdatabase

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>, Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-05-30T20:55:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add new OID alias type regdatabase.

  2. pg_upgrade: Preserve database OIDs.

Nathan Bossart <nathandbossart@gmail.com> writes:
> For now, I've just added another case block for REGDATABASEOID to match the
> others.  If there are problems with non-pinned objects being considered
> shippable, it's not really the fault of this patch.  Also, from reading
> around [0], I get the idea that "shippability" might just mean that the
> same object _probably_ exists on the remote server.  Plus, there seems to
> be very few use-cases for shipping reg* values in the first place.  But
> even after reading lots of threads, code, and docs, I'm still not sure I
> fully grasp all the details here.

It's all quite squishy, unfortunately, because shippability is a
heuristic rather than something we can determine with certainty
(at reasonable cost, anyway).  But I agree with treating regdatabase
the same as the other reg* types, at least until someone shows up
with a counterexample.

			regards, tom lane