Horton

Re: Generating code for query jumbling through gen_node_support.pl

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, "Drouvot, Bertrand" <bdrouvot@amazon.com>
Date: 2023-01-30T10:48:45Z
Lists: pgsql-hackers 
On 27.01.23 03:59, Michael Paquier wrote:
> At the end, that would be unnoticeable for the average user, I guess,
> but here are the numbers I get on my laptop :)

Personally, I think we do not want the two jumble methods in parallel.

Maybe there are other opinions.

I'm going to set this thread as "Ready for Committer".  Either wait a 
bit for more feedback on this topic, or just go ahead with either 
solution.  We can leave it as a semi-open item for reconsideration later.

Commits

  1. Mark more nodes with attribute no_query_jumble

  2. Include values of A_Const nodes in query jumbling

  3. Generate code for query jumbling through gen_node_support.pl

  4. Rework format of comments in headers for nodes

  5. Move queryjumble.c code to src/backend/nodes/

  6. Fix some compiler warnings in aset.c and generation.c

  7. Reformat some node comments