Horton

Re: A few warnings on Windows

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-01T23:39:13Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> Here's a patch that builds warning-free for me.  Result:
> https://ci.appveyor.com/project/macdice/postgres/build/1.0.139

LGTM, pushed.

> Unfortunately my scripting for that doesn't actually build the plperl
> stuff yet (need to cannibalise more buildfarm scripts...) so I can't
> confirm that it'll fix the true/false redefinition warnings visible on
> whelk (VC 2013) and dory (2015) but not hamerkop (2005), thrips
> (2010), bowerbird (2012).  It seems likely.

We'll soon find out.

			regards, tom lane

Commits

  1. Suppress some compiler warnings in plperl on Windows.

  2. Fix compiler warning on Windows.

  3. Change SIZEOF_BOOL to 1 for Windows.

  4. Fix some assorted compiler warnings on Windows.

  5. Clean up warnings from -Wimplicit-fallthrough.