Horton

Re: narwhal and PGDLLIMPORT

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Marco Atzeri <marco.atzeri@gmail.com>, pgsql-hackers@postgresql.org
Date: 2014-02-15T18:17:51Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-02-15 18:21:56 +0100, Andres Freund wrote:
>> On 2014-02-15 12:16:58 -0500, Tom Lane wrote:
>>> Yeah, there are enough copies of that stuff that centralizing them
>>> sounds like a great idea.  Call it "pg_getopt.h", perhaps?

> Patch attached. I am not sure whether HAVE_GETOPT is the best condition
> to use, since it's set by configure by a link based check, same goes for
> HAVE_INT_OPTERR. The other choices would be relying on HAVE_GETOPT_H or
> a new AC_CHECK_DECL.

Thanks.  I'll look this over and try to get it committed before brolga's
next scheduled run.  At least this'll ensure we only have one place to
tweak if more tweaking is needed.

			regards, tom lane