Thread

Commits

  1. Avoid re-writing files unnecessarily in src/tools/copyright.pl.

  2. Fix the dates of some copyright notices

  1. Outdated copyright year in parse_jsontable.c

    Julien Rouhaud <rjuju123@gmail.com> — 2022-04-11T06:08:38Z

    Hi,
    
    I just noticed that parse_jsontable.c was added with a wrong copyright year,
    trivial patch attached.
    
    While at it I also see that a lot of Spanish translation files seems to be
    stuck in 2019, but those were fixed in the pgtranslation repo last June so they
    will get synced eventually.
    
  2. Re: Outdated copyright year in parse_jsontable.c

    Michael Paquier <michael@paquier.xyz> — 2022-04-11T06:58:01Z

    On Mon, Apr 11, 2022 at 02:08:38PM +0800, Julien Rouhaud wrote:
    > I just noticed that parse_jsontable.c was added with a wrong copyright year,
    > trivial patch attached.
    
    Thanks, I'll go fix that in a bit.  I am spotting four more, as of
    src/backend/replication/basebackup_*.c that point to 2020.
    --
    Michael
    
  3. Re: Outdated copyright year in parse_jsontable.c

    Julien Rouhaud <rjuju123@gmail.com> — 2022-04-11T09:16:59Z

    On Mon, Apr 11, 2022 at 03:58:01PM +0900, Michael Paquier wrote:
    > On Mon, Apr 11, 2022 at 02:08:38PM +0800, Julien Rouhaud wrote:
    > > I just noticed that parse_jsontable.c was added with a wrong copyright year,
    > > trivial patch attached.
    > 
    > Thanks, I'll go fix that in a bit.  I am spotting four more, as of
    > src/backend/replication/basebackup_*.c that point to 2020.
    
    Ah right, I now realize that my command found them too but it was hidden with
    the .po files and I missed them.
    
    Thanks!
    
    
    
    
  4. Re: Outdated copyright year in parse_jsontable.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-04-11T13:57:53Z

    Julien Rouhaud <rjuju123@gmail.com> writes:
    > On Mon, Apr 11, 2022 at 03:58:01PM +0900, Michael Paquier wrote:
    >> On Mon, Apr 11, 2022 at 02:08:38PM +0800, Julien Rouhaud wrote:
    >>> I just noticed that parse_jsontable.c was added with a wrong copyright year,
    >>> trivial patch attached.
    
    >> Thanks, I'll go fix that in a bit.  I am spotting four more, as of
    >> src/backend/replication/basebackup_*.c that point to 2020.
    
    > Ah right, I now realize that my command found them too but it was hidden with
    > the .po files and I missed them.
    
    FTR, we already have a tool for this: src/tools/copyright.pl.
    I ran it to check, and it found the same five files.
    
    (I'm slightly annoyed at it for having touched the mod dates on
    every file when it only needed to change five ... will go fix that.)
    
    			regards, tom lane