Horton

Re: remove quoting hacks and simplify bootscanner.l

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-04-17T18:01:23Z
Lists: pgsql-hackers 
John Naylor <jcnaylor@gmail.com> writes:
> For the bootstrap data conversion, it was desirable for postgres.bki
> to remain unchanged, so some ugly quoting hacks were added to
> genbki.pl to match the quoting conventions in the DATA() lines. At
> this point, it's possible (and worthwhile I think) to remove those,
> and along the way simplify the tokenizing rules in bootscanner.l.

Although we're past feature freeze, this all seems like reasonable
code cleanup, and probably best to include it now rather than waiting
for v12.  Any objections?

			regards, tom lane

Commits

  1. Rationalize handling of single and double quotes in bootstrap data.

  2. Rationalize handling of array type names in bootstrap data.

  3. Simplify genbki.pl's data quoting rules.