Horton
Menu

Re: Experiments with Postgres and SSL

Heikki Linnakangas <hlinnaka@iki.fi>

View thread
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Jacob Champion <jacob.champion@enterprisedb.com>, Greg Stark <stark@mit.edu>, Andrey Borodin <amborodin86@gmail.com>, Vladimir Sitnikov <sitnikov.vladimir@gmail.com>, Michael Paquier <michael@paquier.xyz>
Date: 2024-04-08T01:40:00Z
Lists: pgsql-hackers 
On 08/04/2024 04:28, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Committed this. Thank you to everyone involved!
> 
> Looks like perlcritic isn't too happy with the test code:
> koel and crake say
> 
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - chmod at line 138, column 2.  See pages 208,278 of PBP.  ([InputOutput::RequireCheckedSyscalls] Severity: 5)
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - open at line 184, column 1.  See pages 208,278 of PBP.  ([InputOutput::RequireCheckedSyscalls] Severity: 5)

Fixed, thanks.

I'll make a note in my personal TODO list to add perlcritic to cirrus CI 
if possible. I rely heavily on that nowadays to catch issues before the 
buildfarm.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Enhance libpq encryption negotiation tests with new GUC

  2. With gssencmode='require', check credential cache before connecting

  3. Add tests for libpq gssencmode and sslmode options

  4. Move Kerberos module

  5. Give nicer error message when connecting to a v10 server requiring SCRAM.