Horton

Thread

Commits

  1. Remove unused configure variable.

  1. Another dead configure test

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-08-18T15:04:03Z

    I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
from tclConfig.sh, and puts the value into Makefile.global,
but then we never use it anywhere.  AFAICT the only use went
away in cd75f94da, in 2003.  I propose the attached.

			regards, tom lane

  2. Re: Another dead configure test

    Andres Freund <andres@anarazel.de> — 2022-08-18T16:56:30Z

    Hi,

On 2022-08-18 11:04:03 -0400, Tom Lane wrote:
> I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
> from tclConfig.sh, and puts the value into Makefile.global,
> but then we never use it anywhere.  AFAICT the only use went
> away in cd75f94da, in 2003.  I propose the attached.

Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
isn't used either afaics?

Greetings,

Andres Freund

  3. Re: Another dead configure test

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-08-18T17:00:28Z

    Andres Freund <andres@anarazel.de> writes:
> Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> isn't used either afaics?

I wondered about that, but we do need TCL_SHARED_BUILD in configure
itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
We could remove the line in Makefile.global but I don't think that
buys much, and it might be more confusing not less so.

			regards, tom lane

  4. Re: Another dead configure test

    Andres Freund <andres@anarazel.de> — 2022-08-18T17:20:50Z

    Hi,

On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> > isn't used either afaics?
> 
> I wondered about that, but we do need TCL_SHARED_BUILD in configure
> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
> We could remove the line in Makefile.global but I don't think that
> buys much, and it might be more confusing not less so.

From the meson-generates-Makefile.global angle I like fewer symbols that have
to be considered in Makefile.global.in :). But even leaving that aside, I
think it's clearer to not have things in Makefile.global if they're not used.

But it's obviously not important.

Greetings,

Andres Freund

  5. Re: Another dead configure test

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-08-18T18:20:46Z

    Andres Freund <andres@anarazel.de> writes:
> On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
>> I wondered about that, but we do need TCL_SHARED_BUILD in configure
>> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
>> We could remove the line in Makefile.global but I don't think that
>> buys much, and it might be more confusing not less so.

>> From the meson-generates-Makefile.global angle I like fewer symbols that have
> to be considered in Makefile.global.in :). But even leaving that aside, I
> think it's clearer to not have things in Makefile.global if they're not used.

> But it's obviously not important.

Yeah, I'm not excited about it either way --- feel free to change
if you'd rather.

			regards, tom lane