Horton

Re: The output sql generated by pg_dump for a create function refers to a modified table name

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-02-17T15:09:35Z
Lists: pgsql-hackers 
"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> Good catch. Do you have thoughts on how we can adjust the naming logic 
> to handle cases like this?

I think it's perfectly fine that ruleutils decided to use different
aliases for the two different occurrences of "t1": the statement is
quite confusing as written.  The problem probably is that
get_delete_query_def() has no idea that it's supposed to print the
adjusted alias just after "DELETE FROM tab".  UPDATE likely has same
issue ... maybe INSERT too?

			regards, tom lane

Commits

  1. Print the correct aliases for DML target tables in ruleutils.