Horton
Menu

Re: [PATCH] Make pg_basebackup configure and start standby [Review]

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Peter Eisentraut <peter_e@gmx.net>, Amit Kapila <amit.kapila@huawei.com>, 'Hans-Jürgen Schönig' <hs@cybertec.at>, "'Pg Hackers'" <pgsql-hackers@postgresql.org>, Magnus Hagander <magnus@hagander.net>, Fujii Masao <masao.fujii@gmail.com>
Date: 2012-10-04T14:43:15Z
Lists: pgsql-hackers 
Boszormenyi Zoltan <zb@cybertec.at> writes:
>> Did you think about something like the attached code?

> Or rather this one, which fixes a bug so fillPGconn() and PQconninfo() are
> symmetric and work for "requiressl".

That's incredibly ugly.  I'm not sure where we should keep the "R"
information, but shoehorning it into the existing PQconninfoOption
struct like that seems totally unacceptable.  Either we're willing to
break backwards compatibility on the Disp-Char strings, or we need
to put that info somewhere else.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make the streaming replication protocol messages architecture-independent.